Skip to content

refactor: merge lend create and manage loan + vault pages #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielSchiavini merged 17 commits into from
Dec 17, 2025
Merged

refactor: merge lend create and manage loan + vault pages #1736

DanielSchiavini merged 17 commits into from
Dec 17, 2025

Conversation

@DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Dec 3, 2025 •
edited
Loading

This change is to merge the loan creation and manage pages for all lend markets

  • until now we had different URLs for creating and managing a loan
  • that meant if you landed in the wrong page you might see a totally wrong image of your loan
  • there were redirects in place from one to the other, but these were complex and buggy
  • instead, we now just look at your wallet, if you have an open loan the page reacts to it, no redirects necessary
  • less complexity, less bugs, less urls, less redirects, less code 🙏 but no change in functionality for the users
  • similar refactor: merge mint create and manage loan pages #1749
  • depends on refactor: form tabs #1747

@vercel
Copy link

vercel bot commented Dec 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
curve-dapp Ready Ready Preview, Comment Dec 17, 2025 7:43pm
curve-dapp-storybook Ready Ready Preview, Comment Dec 17, 2025 7:43pm

@DanielSchiavini DanielSchiavini mentioned this pull request Dec 3, 2025
Merged
18 tasks
@DanielSchiavini DanielSchiavini marked this pull request as ready for review December 3, 2025 14:03
@DanielSchiavini DanielSchiavini marked this pull request as draft December 3, 2025 14:06
@DanielSchiavini DanielSchiavini marked this pull request as ready for review December 3, 2025 14:21
0xtutti
0xtutti previously approved these changes Dec 3, 2025
View reviewed changes
0xPearce
0xPearce requested changes Dec 4, 2025
View reviewed changes
Copy link
Collaborator

@0xPearce 0xPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two "Borrow" tabs in Legacy mode. Example WBTC <> crvUSD lend market

Preview curve.finance
Image Image

@0xPearce
Copy link
Collaborator

0xPearce commented Dec 4, 2025

Great refactor! 🙏

Base automatically changed from refactor/routes to main December 4, 2025 16:16
@DanielSchiavini DanielSchiavini dismissed 0xtutti’s stale review December 4, 2025 16:16

The base branch was changed.

0xAlunara
0xAlunara previously approved these changes Dec 4, 2025
View reviewed changes
DanielSchiavini added a commit that referenced this pull request Dec 15, 2025
@DanielSchiavini
fix: add spacing for no position
3e18944 
this makes the page consistent with the lend markets in #1736
OnlyJousting
OnlyJousting previously approved these changes Dec 15, 2025
View reviewed changes
Base automatically changed from revert-1745-revert/refactor/routes to main December 17, 2025 09:09
@DanielSchiavini DanielSchiavini dismissed stale reviews from OnlyJousting and 0xAlunara December 17, 2025 09:09

The base branch was changed.

OnlyJousting
OnlyJousting previously approved these changes Dec 17, 2025
View reviewed changes
0xPearce
0xPearce previously approved these changes Dec 17, 2025
View reviewed changes
@DanielSchiavini DanielSchiavini changed the title refactor: merge lend create and manage loan pages refactor: merge lend create and manage loan + vault pages Dec 17, 2025
@DanielSchiavini DanielSchiavini merged commit 00826b6 into main Dec 17, 2025
25 of 26 checks passed
@DanielSchiavini DanielSchiavini deleted the refactor/merge-lend-routes branch December 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@0xAlunara 0xAlunara 0xAlunara approved these changes

@OnlyJousting OnlyJousting OnlyJousting approved these changes

@0xPearce 0xPearce 0xPearce left review comments

@0xtutti 0xtutti 0xtutti left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@DanielSchiavini @0xPearce @0xAlunara @OnlyJousting @0xtutti